Why char** dynamic_string_array(int ROWS, int SIZE) doesn't work properly?

Hi,please help...
It works fine when I define a 2-D array like char code[ROWS][SIZE].
But it won't work when I try to define the array dynamically using a
function. It just crashes.
Does anyone know why?
The compiler i'm using is Dev c++.


#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int file_length(FILE *file);
void down_string(char *p);
char* issubstring(char *str1,char *str2);
char** dynamic_string_array(int ROWS, int SIZE);

int main(void)
{
  int row,n,i,coursefound=0,ROWS,SIZE,test;

  FILE *datafile;
  datafile=fopen("3rdyear.csv", "rb");
  ROWS=file_length(datafile);

  printf("Has %d lines\n",ROWS);

  char **Code,**Course,**ClassSize,**Time1,**Time2,**Room,c;
  char search[30];


  Code=dynamic_string_array(ROWS,SIZE);
  Course=dynamic_string_array(ROWS,SIZE);
  ClassSize=dynamic_string_array(ROWS,SIZE);
  Time1=dynamic_string_array(ROWS,SIZE);
  Time2=dynamic_string_array(ROWS,SIZE);
  Room=dynamic_string_array(ROWS,SIZE);


  for (row=0; row <ROWS; row++) {
  test=fscanf(datafile, "%[^,],%[^,],%[^,],%[^,],%[^,],%[^\n]\n",
  Code[row],Course[row],ClassSize[row],
  Time1[row],Time2[row],Room[row]);


  printf("row=%d,scanf converted %d (%s,%s,%s,%s,%s,%s)\n",
  row, test,

Code[row],Course[row],ClassSize[row],Time1[row],Time2[row],Room[row]);
}


printf("Please enter a name\n>");
  scanf("%s",search);


  for(i=1; i<ROWS; i++) {
      if(issubstring(Course[i],search))  {
                coursefound=1;
                printf("Course %s found!!\nTime 1 is %s\nTime2 is
%s\nVenue:%s",Course[i],Time1[i],Time2[i],Room[i]);

           }
   }
   if(coursefound==0) printf("No such Course!.\n");
  fclose(datafile);


 return EXIT_SUCCESS;

}


void down_string(char *p)  //turns uppercase letters in a string to
lowercase
{
    int i;
    for(i=0;p[i]!='\0';i++)
    {
        if((p[i]>='A')&&(p[i]<='Z')) p[i]+=32;
    }
}


char* issubstring(char *str1,char *str2)  //checks if string2 is a
substring of string2
{
    char tmp1[30],tmp2[30];
    strcpy(tmp1, str1);
    strcpy(tmp2, str2);
    down_string(tmp1);  //turn it to lowercase
    down_string(tmp2);
    return (strstr(tmp1, tmp2));


}

char** dynamic_string_array(int ROWS, int SIZE)
{
  char **array;
  int i;
  array=(char**) malloc(ROWS*sizeof(char));
  for(i=0;i<ROWS;i++)
     array[i]=(char *) malloc(SIZE*sizeof(char));

  return array;
}


int file_length(FILE *file)
{
  int lines;
  char dummy[100];

  rewind(file);

  lines=0;
  while( fgets(dummy, 100, file) != NULL)
    lines++;

  rewind(file);

  return(lines);
}

In article < XXXX@XXXXX.COM >,


:It works fine when I define a 2-D array like char code[ROWS][SIZE].
:But it won't work when I try to define the array dynamically using a
:function. It just crashes.
:Does anyone know why?

:char** dynamic_string_array(int ROWS, int SIZE)
:{
:  char **array;
:  int i;
:  array=(char**) malloc(ROWS*sizeof(char));

You probably want malloc(ROWS*sizeof(char*))
seeing as you are going to be storing in character pointers.

:  for(i=0;i<ROWS;i++)
:     array[i]=(char *) malloc(SIZE*sizeof(char));
:
:  return array;
:}
-- 
Would you buy a used bit from this man??

SIZE has not been initialized.  Perhaps your compiler could have been so 
kind as to help you with that...

foo.c:12: warning: `SIZE' might be used uninitialized in this function

-David

 XXXX@XXXXX.COM  (Walter Roberson) writes:


There's no need to cast the result of malloc() in C.  (Two people in
this newsgroup will disagree with that; one has good reasons to write
code that compiles both as C and as C++, the other is wrong.)

It's also a good idea, in a malloc() call, to use the size of what the
result points to, not the size of a type that can change or that you
can get wrong.

The best way to do the above is:

    array = malloc(ROWS * sizeof *array);

-- 
Keith Thompson (The_Other_Keith)  XXXX@XXXXX.COM   < http://www.**--****.com/ ~kst>
San Diego Supercomputer Center             <*>  < http://www.**--****.com/ ~kst>
We must do something.  This is something.  Therefore, we must do this.

Sorry i had sent the wrong version, so it had a few minor errors.
But the problem in question was solved by replacing sizeof(char) with
sizeof(*array) as you adviced.
Thanks.





code[ROWS][SIZE].
a
the
< http://www.**--****.com/ ~kst>
< http://www.**--****.com/ ~kst>
this.

What happens when the strings are longer than 29 characters?

You'd be better off to roll your own stristr function that
doesn't need to allocate any memory.