Problem with FileWriter class


    Sponsored Links


  • 1. wrap httpservletrequest and session in threadlocal variable
    Hi, I'm in the process of refactoring a web application (business logic in the action classes), which has lots of references to httpservletrequest and httpsession. I'm planning to wrap the request and session variables through two static classes, containing threadlocal variables, and ititialising it in through a filter to prevent the code from breaking during the refactor process. Is it a good idea to do this? Thanks,
  • 2. primitive collections....which is best?
    Hi all, We are revamping some packages that use one of the primitive collections out there ( but we know there are others, for example, the Trove library). Any recommendations or insights? Is it worth switching? Any clear preferred package? Also, we did think about replacing the primitive collections with the 5.0 boxin/unboxing + generics, but from all we've seen the performance penalties are too great. So we stick with the primitives... Thanks for any insights Alejandrina
  • 3. XML formatting LF/CR?
    I cant get the java api to use linefeed and carriage return in the xml that im producing: StreamResult result = new StreamResult(output); DOMSource source = new DOMSource(doc); Transformer transformer = TransformerFactory.newInstance().newTransformer(); transformer.setOutputProperty(OutputKeys.INDENT, "yes"); transformer.setOutputProperty(OutputKeys.ENCODING, "UTF-8"); transformer.transform(source, result); The xml produced is a single line. What is needed to "pretty print" the xml?
  • 4. How to develop using
    Rodger wrote: > Have you guys ever .. ..been a reposting, multi-posting, spammer moron that attempts to hide his blatant advertising as though it were coming from a 'motivated end user'? No, but I know a few (hundred), of which you are simply the latest in a long line. P*ss off. (Again). Andrew T.

Problem with FileWriter class

Postby nimmi_srivastav » Tue, 22 Jul 2003 00:58:10 GMT

rief:- I am having trouble getting a FileWriter to write to a
non-existent file if I instantiate the FileWriter with a String that
is manipulated at run time. It works fine with a hard-coded char
array. The error that I get in the former case is:
(The specified path is invalid)tion

Detailed:- This is my first serious foray into Java ----- I recently
completed the Hello World program ----- so my apologies if I am not
doing things the right way (which, I am sure is the case).

I am trying to write a Java application that reads a list of URLs from
a file and accesses each URL and stores it associated web-page locally
on the file system. The filename associated with each webpage is the
same as its URL except that the following characters are replaced by
the '^' character:

I am not getting any error if I uncomment the line that says
//[UNCOMMENT ME] and comment the immediately preceding line (which
says [COMMENT ME]).

I was also able to successfully get the application to work by
maintaining an array of hard-coded strings and indexing into that
array for each iteration of the main loop.

Here's the program listing. Again my apologies for not doing things
the "right" way:

=======================Program Listing begin ==================


public class URLDownloader
public static void main(String[] args) throws Exception
if(args.length == 0)
System.out.println("usage: <this-utility> <filename>");

File inputFile = new File(args[0]);

FileInputStream finStm = new FileInputStream(inputFile);
int ret;

StringBuffer urlAddr = new StringBuffer("");
char c;

DataInputStream inStm = null;

while ((ret = != -1)
if((c = (char) ret) != '\n')

int len = urlAddr.length();
if(len <= 1)

URL thisURL = new URL(urlAddr.toString());
inStm = new DataInputStream(thisURL.openStream());
catch (Exception xcpn)
// FileNotFoundException, ProtocolException,
urlAddr.delete(0, len);
System.out.println("Error: " + xcpn.toString());

String urlAddrStr = new String(urlAddr);
StringBuffer urlFile = new StringBuffer(urlAddrStr);
for(int i=0; i < urlFile.length(); i++)
char ch = urlFile.charAt(i);
case '/':
case '\\':
case ':':
case '*':
case '?':
case '\"':
case '<':
case '>':
case '|':
urlFile.setCharAt(i, '^');


String fileName = new String(urlFile);
FileWriter fWriter = new FileWriter(fileName); // [COMMENT ME]
//[UNCOMMENT ME] FileWriter fWriter = new

String inputLine;

while ((inputLine = inStm.readLine()) != nul

Re: Problem with FileWriter class

Postby FGB » Tue, 22 Jul 2003 03:20:22 GMT

It worked ok for me.  I uncommented the line that creates fileName(s) 
and used the a "data file" with the following URLs:


Not sure what is happening for you...

Fred Burkley

Re: Problem with FileWriter class

Postby Steve Horsley » Tue, 22 Jul 2003 05:57:32 GMT


I suspect you have the wrong file name. Instead of using:
try using:
    System.out.println("fileName = '" + fileName + "'");
This should show up any unexpected characters such as '\r'.

If you want to read a text file, you would be better off treating it as a
text file and using a Reader. This way you will more likely get the
characterset right, and handle line endings better.


Re: Problem with FileWriter class

Postby nimmi_srivastav » Fri, 25 Jul 2003 04:02:49 GMT

Since the original posting, I have tried this program on Solaris.  It
works fine on Solaris, but on Windows (98 & 2000) I keep getting error
messages.  Could someone kindly try it out on Windows and share their
experience please?


Re: Problem with FileWriter class

Postby sandeep6699 » Thu, 07 Aug 2003 19:56:06 GMT


I tried your program on Solaris and Windows, and I ran into similar
problems on Windows.  It worked fine on Solaris.


Re: Problem with FileWriter class

Postby weichao_wang » Tue, 19 Aug 2003 21:36:59 GMT

Replace the code above with the following, it may work on Windows:

        if((c = (char) ret) != '\r')
        } else {
          ret =;  // skip '\n'

The reason is that the line end is '\n' on Unix whereas it is '\r\n'
on Windows/DOS.
I have not tested the code (because of firewall?). If someone has tested
it, please post the result here.


Re: Problem with FileWriter class

Postby nobody » Wed, 20 Aug 2003 14:47:41 GMT

Roedy Green < XXXX@XXXXX.COM > writes:

Roedy, if you look at the original, very old posting, you will see that
the problem is not the FileWriter. There are a number of problems in
the original code, including:

- Using an InputStream and not a Reader to read some text file

- Doing line-by-line reading via the InputStream with a home-made EOL
  detection that will break on any file not using the Unix convention,
  instead of using a LineReader.

- Usage of a DataInput stream for reading from a URL, serving no
  apparent purpose other then messing up the input data.

- Improper handling of empty lines (might be an artefact of the
  problems with handling EOL).

- Rather strange mixture of using String and StringBuffer, including
  converting a StringBuffer to a String and back to a StringBuffer on
  the next line, multiple times converting the same StringBuffer (with
  the same contents) to a String, etc.

- Improper attempt to convert a URL to a local file name (here the
  broken EOL detection can sneak control chars into the name, and some
  valid URL chars are not handled at all, like '=', '&', or '%').

  And the control char \r from the name is why the creation of the
  FileWriter breaks.

- Usage of the deprecated DataInputStream.readLine() to read a String.

- Usage of FileWriter to write bytes - which have just been converted
  from the String gotten from DataInputStream.readLine() ...

- Manual memory handling: Manually clearing existing objects instead of
  just creating new ones.

And I might have missed a few things.

remains have to be treated as toxic waste. Please, leave it alone.


Similar Threads:

1.Problem with FileWriter


I'm writing a simple Web application that gets image data from a
third-party applet and writes it to a specified directory on a Web
server (this is done using a JSP and a JavaBean handling the file

When I upload any *.jpg and attempt to write it to the server,
however, the size of  the copied image on the server directory is
exactly the same, but when I try to open the file, I get "No Preview
Available" from Windows Picture and Fax Viewer, "Can't determine type"
from Microsoft Photo Editor, etc.

Here is the code that I used to read from the applet source and write
to the server:

try {	
        // get the image input from applet
      	ServletInputStream in = request.getInputStream();
      	FileOutputStream ostrm = new FileOutputStream("picture4.jpg");
      	byte[] readArray = new byte[1];       	
      	while(( != -1)
      	// close all streams
	return true;
      } catch (Exception e) {
      	System.out.println("check console");
      	return false;

Can anyone help me out?

2.FileWriter Problem

I get problem using FileWriter when I insert "/n" in it .It shows some
ugly square instead of going to the new line
I tried following code
class Writer
	public static void main(String args[])
		String str ="Rahul is writing this piece\n"
			         +"I know that black square will come in place of newline
			          +"I there anybody who can help me\n";
		char [] ch = new char[str.length()];
			FileWriter fw =new FileWriter("testfile.txt");
		catch(IOException ioe){}
Please help in case you have a solution to this problem
Thanking in anticipation
Rahul Sharma

3.problem writing doubles with java filewriter

I can write strings fine but can't write doubles. Do I have to close
the file and try writing with another method?

4.FileWriter.write() does not fail if file is removed after being opened

This may be an OS thing, but FileWriter.write(Sting,int,int) thinks it
is writing ok when I remove the file it is writing to after the file
has been opened.  No exception is thrown, because the line directly
after the write() and flush() within the try block is executed (I am
catching Exception if that matters).  I am speculating that the OS is
not notifying the owner of the file handle (if I an saying it right)
that the file has been deleted / removed / whatever, and that this
might function differently on different systems.

I am trying to create a failover for a log writing thread, and I am
removing the file to simulate an IO error, hehe but that's not
working.  Is there a) a better way to simulate an IO error?  and b) a
more primitive write method that might throw an exception in this
unlikely circumstance?


clh and encoding


I recently changed the hosting for my website (from Linux to Linux) and 
now I'm experiencing some trouble with and their getEncoding() method returns ASCII (returned 
ISO8859_1 on the previuos host). I've set -Dfile.encoding=ISO-8859-1 but 
nothing has changed, except that 
javax.mail.internet.MimeUtility.getDefaultJavaCharset() effectively 
returns ISO-8859-1.

Does anyone know how the default encoding is selected? I report some 
system properties:

file.encoding.pkg: US
java.runtime.version: 1.4.2_04-b05
os.version: 2.4.27
user.timezone: America/New_York
file.encoding: ISO-8859-1
user.language: en
java.version: 1.4.2_04
java.vendor: Sun Microsystems Inc.


6. Absolute path / creating FileWriter-object

7. FileWriter and Path

8. Cant find

Return to JAVA


Who is online

Users browsing this forum: No registered users and 80 guest