[linux-usb-devel] [PATCH 01/02] USB: sierra: Add TRU-Install (c) Support [ATTEMPT 4]

Am Freitag 13 Juli 2007 schrieb Kevin Lloyd:
> +nt result;>> +truct usb_device *udev;
>> +
>> +dev = usb_get_dev(interface_to_usbdev(iface));
>> +
>> +* Check if in installer mode */>
> +f (i>->driver_info == DEVICE_INSTALLER){>
> +ev_dbg(&ude>->dev, "%s", "FOUND DEVICE(SW)\n");>
> +esult = sierra_set_ms_mode(udev, SWIMS_SET_MODE_Modem);>
> +eturn result;

As I mentioned, you'd better return -EIO here. You don't want to bind
to the device, as it is not yet a serial device and you want the driver core
to stop trying while it goes away and transforms itself.

	Regards
		Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to  XXXX@XXXXX.COM 
More majordomo info at   http://www.**--****.com/ 
Please read the FAQ at   http://www.**--****.com/ 

Ah, thanks for spelling it out for me :) I misunderstood you before.

- Kevin 

-----Original Message-----
From: Oliver Neukum [mailto: XXXX@XXXXX.COM ] 
Sent: Monday, July 16, 2007 4:55 AM
To:  XXXX@XXXXX.COM 
Cc: Kevin Lloyd;  XXXX@XXXXX.COM ; Linux Development Group;  XXXX@XXXXX.COM ;  XXXX@XXXXX.COM 
Subject: Re: [linux-usb-devel] [PATCH 01/02] USB: sierra: Add TRU-Install (c) Support [ATTEMPT 4]

Am Freitag 13 Juli 2007 schrieb Kevin Lloyd:

As I mentioned, you'd better return -EIO here. You don't want to bind to the device, as it is not yet a serial device and you want the driver core to stop trying while it goes away and transforms itself.

	Regards
		Oliver


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to  XXXX@XXXXX.COM 
More majordomo info at   http://www.**--****.com/ 
Please read the FAQ at   http://www.**--****.com/