Validating field values using an array

The code below is sliced out of my latest efforts. I have a form with
some fields that are mandatory and ortehrs not. to test them I am
trying to use an array with the names of the mandatory fields. But it
will only ever report invalid even when it shold be OK. I#m sure it's
something simple that i can't see for looking. Can anyone spot the
problem?

'   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
'   Initialise the mandatory fields array etc.
'   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    valuesMandatoryFields() = Array _
        ("DocTitle", "DocSubject", "DocAuthor",
"DocPublicationStatus", "DocVersion", "DocType")
'   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
'   Check each field
'   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    For Each conControl In Me.Controls
        If LCase(TypeName(conControl)) = "textbox" Then
            'strMsgInsert = conControl.Name                          '
debug
            'MsgBox "checking field " & strMsgInsert, vbOKOnly
                If IsFieldMandatory(conControl.Name) = True Then    '
it's a mandatory field
                    If Not Len(Trim(conControl.Text)) > 0 Then      '
and they haven't entered anything so
                        booEntryValid = False                       '
set flag so that returns to user
                    End If
                End If
        End If
    Next

'   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
'   Either exit to process valid or return invalid to user
'   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    If booEntryValid = True Then
        MsgBox "all Ok"
        Me.Hide                                                    '
valid entry so return control to calling module
    Else                                                            '
invalid entry ask them to try again
        MsgBox "You have not entered one or more of the mandatory
field please try again"
        DocTitle.SetFocus
'set focus to first field before returning control to user
    End If

The Function is like this:

Private Function IsFieldMandatory(varFieldToTest) As Boolean
    For Each varMandatoryField In valuesMandatoryFields
        IsFieldMandatory = (varMandatoryField = varFieldToTest)
    Next
End Function

thank you

luca

Do you set booEntryValid = True anywhere?

Peter Jamieson

On 17 Jun, 16:22, "Peter Jamieson" < XXXX@XXXXX.COM >





I thought I replied to this but obviously not... Yes immediatelt
before initialising the array, I also realise that I had said it is
always invalid, I should have said valid!