Does using AfxBeginThread() require AfxEndThread()?

VC

    Sponsored Links

    Next

  • 1. Newbie Subclassed Constructor Questions
    Hi, I've subclassed the listbox control so I can make it do what I require, it has 2 constructors. I am using the new List Box in a dialog based mfc app. CListBoxEx::CListBoxEx() CListBoxEx::CListBoxEx(UINT FileFlags, CString FileSpec) After a bit of searching I found some example code showing how these constructors should be called. So I have the following in my Dialog based class: CViceMP3Dlg::CViceMP3Dlg(CWnd* pParent /*=NULL*/) : CDialog(CViceMP3Dlg::IDD, pParent), m_lbMP3List(DDL_READWRITE, _T("*.*")) with m_lbMP3List being the ListBoxEx variable. my question is, what does ": CDialog(CViceMP3Dlg::IDD, pParent), m_lbMP3List()" mean? Clearly it's to call constructors. But I haven't come accross it before so i'm a little confused as to what it does. Also, is this the best way to do it? Can I construct my ListBox somewhere else? So that I could pass variables rather than literals as constructor parameters? Thanks for your help! James Smaldon.
  • 2. CRichEditCtrl Tab
    hi, does anyone tell me how to set the tab size to 4 instead of 8 characters width? Thanks.
  • 3. CTreeCtrl : duplicating / moving HTREEITEMs
    How do I move or duplicate a HTREEITEM (+ childs) in a CTreeCtrl without deleting and recreating them?
  • 4. Calling Send Message kills outlook express!
    Hi, I load and unload some custom fonts in my app, and, as MSDN says, i call SendMessage(HWND_BROADCAST, WM_FONTCHANGE, 0,0); after loading or unloading using AddFontResource(...) and RemoveFontResource(...). The fonts i use are NOT windows std fonts, they are created dynamicly by my app. Every time this message is sent, the toolbar on OE jumps and after several calls, its completly unusable. Am i doing somthing wrong or is this just a bug in OE? Only the main wnd of OE appears to be affected, IE did nothing. (using WinXP will SP1a, and OE 6) Joe #
  • 5. #include for InternetGetConnectedState?
    Hello everyone, My application is written using MSVC++ 6.0 and it runs on Win 2k, 9x, etc. I am trying to use the functions InternetGetConnectedState() and InternetDial(), but cannot get through the compile - MSVC doesn't recognize it. Does anyone know the include file for this (it is not stated in the documentation) or the preprocessor definition which would allow me to use these API's? Will I have to install any IIS stuff or something like that? Any help would be appreciated.... Thanks, Robert

Re: Does using AfxBeginThread() require AfxEndThread()?

Postby Scott McPhillips [MVP] » Thu, 02 Sep 2004 08:11:06 GMT




The call to AfxEndThread is not needed and is considered harmfull.  The 
reason it is not needed is that the return 0 returns to MFC code that 
closes the thread handle.  The reason it is considered harmfull is that 
it never returns.  The thread ceases to exist during the call, and 
therefore the destructors of any objects created on the stack never get 
invoked.

-- 
Scott McPhillips [VC++ MVP]


Re: Does using AfxBeginThread() require AfxEndThread()?

Postby Joseph M. Newcomer » Thu, 02 Sep 2004 23:33:06 GMT

No, and I consider using AfxEndThread to be poor programming practice. A thread should
terminate solely by returning from its top-level function. The place where you showed
AfxEndThread is pointless, because if you look at the code in MFC, you see that it will be
called almost immediately upon return anyway, but I believe that the return should never
be short-circuited.
					joe





Joseph M. Newcomer [MVP]
email:  XXXX@XXXXX.COM 
Web:  http://www.**--****.com/ 
MVP Tips:  http://www.**--****.com/ 

Re: Does using AfxBeginThread() require AfxEndThread()?

Postby Joseph M. Newcomer » Thu, 02 Sep 2004 23:34:29 GMT

You missed the part where I set m_bAutoDelete to FALSE before doing the ResumeThread.
				joe






Joseph M. Newcomer [MVP]
email:  XXXX@XXXXX.COM 
Web:  http://www.**--****.com/ 
MVP Tips:  http://www.**--****.com/ 

Re: Does using AfxBeginThread() require AfxEndThread()?

Postby Joseph M. Newcomer » Thu, 02 Sep 2004 23:35:50 GMT

ust make sure that the m_bAutoDelete is set before the ResumeThread.
joe

On Tue, 31 Aug 2004 15:09:04 -0700, RNEELY < XXXX@XXXXX.COM > wrote:


Joseph M. Newcomer [MVP]
email: XXXX@XXXXX.COM
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm

Similar Threads:

1.Using AfxBeginThread to create a worker thread...

Code that creates the thread...

m_pListenerThread = (CWinThread*)AfxBeginThread(
(AFX_THREADPROC)ListeningThreadFunction, (LPVOID)this );
ASSERT( m_pListenerThread );


Function that the thread is to run (code stripped out)...


UINT ListeningThreadFunction( LPVOID in_pParam )
{
    while(1)
    {}
}

In both Debug and Release builds, the call to AfxBeginThread hangs
infinitely in thrdcore.cpp, specifically at the function:

BOOL CWinThread::CreateThread(DWORD dwCreateFlags, UINT nStackSize,
LPSECURITY_ATTRIBUTES lpSecurityAttrs)

at the WaitForSingleObject line:

VERIFY(ResumeThread() != (DWORD)-1);
VERIFY(::WaitForSingleObject(startup.hEvent, INFINITE) == WAIT_OBJECT_0);

Now, it has been a long time since I've used a worker thread as opposed to a
GUI thread and I remember that they were trivial to use...

Any suggestions why AfxBeginThread would hang itself?

BTW, the overview of how this all gets called is:

    Application calls an exposed DLL function, the DLL instantiates and
creates a series of classes to use internally, eventually the class which
needs this worker thread to 'listen' gets created.  After the class is
created, an initialization function is called on the class which creates
this thread as you see above.

    Any glaringly stupid things I'm doing/forgetting?

    WTH


2.Using Afxbeginthread

Hi
I have used AfxbeginThread with ThreadProc as first argument. i wantd to ask
what is the use of second type of AfxBeginThread that takes CRunTimeClass *
as parameter..also how to use it..i mean in the first type we just have to
write our code to be executed in the thread with in that Thread function
that is passes as first argument to AfxBeginthread, but what about the other
type..where do we write our code in the second type of this API. could
someone please give me an example coz i cud'nt understand whats written in
msdn..also i didnt find any good example clearly indicating API usage with
CRunTime argument.

Thanx and Regards

Usman Jamil


3.Not understanding 'AfxEndThread'

Hello all,

   I have an app that creates a UI thread, and a worker thread to wait for 
the handle of the UI thread.   But, in the UI thread when I do a 
'AfxEndThread(0,0)'
I get an Assert error:

In the app's view:
void CJunkThreadView::OnButton1() 
{
    pAnyThread = (CAnyThread*)AfxBeginThread(RUNTIME_CLASS(CAnyThread),
	         THREAD_PRIORITY_NORMAL, 0, CREATE_SUSPENDED);
    ASSERT_VALID(pAnyThread);

     //fire off a worker thread to wait for the UI's handle
     if(!(pWrkThd_1 = AfxBeginThread(WrkThread_1,this)))
       return;

    //Let the UI go
     RunUIThread();
}
void CJunkThreadView::RunUIThread()
{
  pAnyThread->m_bAutoDelete = FALSE;
  pAnyThread->ResumeThread();
  Sleep(1000);
  pAnyThread->RunIt();

}
UINT WrkThread_1(LPVOID lParam)
{
    CJunkThreadView* pMe = (CJunkThreadView*)lParam;

    switch(WaitForSingleObject(pMe->pAnyThread->m_hThread,10000))
       {
          case WAIT_OBJECT_0:
		 AfxMessageBox("0");
		 break;
          case WAIT_TIMEOUT:
		 AfxMessageBox("1");
		 break;
       }
   return 1;
}

///---------------------------------------------------------------------------
 'CAnyThread' is the UI thread whose base class is CWinThread and for testing
it has only one function:
void CAnyThread::RunIt()
{
    Sleep(2000);
    AfxMessageBox("Ending Any Thread");

   /*causes assert */
   AfxEndThread(0,0);
}


   I've tried just returning from 'RunIt', which doesn't cause an assert, 
but I
don't get a ' pMe->pAnyThread->m_hThread' handle signalled in the waiting
worker thread.

   Obviously, I don't understand something? Any help appreciated.

TIA,

Ray K.

 

4.Is there any difference between AfxEndThread and TerminateThread ?

Hi,

Is there any difference between AfxEndThread and TerminateThread ? I
know we can use AfxEndThread from within the thread only but any other
difference like, cleaning up or so.. ??

Jigar

5.thread never calls AfxEndThread

Hi,

I have made a simple app with only one button that starts or stop a loop.
This loop is actually a thread.
In my OnInitDialog I create the thread in a suspended state and when I 
click on Start I resume the thread and when it's stop I suspend it.
Here is the code

CTestDlg* pThis;

BOOL CTestDlg::OnInitDialog()
{
...
if (!(m_pThread = AfxBeginThread(
		thScanCarte,
		this,
		THREAD_PRIORITY_NORMAL,
		0,
		CREATE_SUSPENDED,
		NULL)))
	{
		AfxMessageBox(_T("Cannot create thread"));
		return false;
	}
...
}

/* static */
UINT CTestDlg::thScanCarte( LPVOID pParam )
{
	  pThis = (CTestDlg*) pParam;
	  return pThis->thScanCarte();
}

UINT CTestDlg::thScanCarte()
{
	USHORT status;
	CString s;
	bool bFlag = true;

	while(1)
	{
		if (m_bExitThread){
			TRACE(_T("exit thread"));
			AfxEndThread(1);
		}
		
		TRACE(_T("scanthread\n"));
		Sleep(800);
	}
	return 0;
}


void CTestDlg::OnClose()
{
	USHORT status;

	StopThread();
	m_bExitThread = TRUE;
	m_card.Close();

	CDialog::OnClose();
}


The problem is when my app exitI cannot see the trace 'exit thread'.
I think this code never called but why ?
When the app exits I suspend the thread so I suppose this is why
it is never called.

6. AfxEndThread problem

7. Can this be done using C#

8. Can this be done using a Data adapter??



Return to VC

 

Who is online

Users browsing this forum: No registered users and 17 guest