DoLayoutAdaptation()

by **John Roberts** » Wed, 21 Jan 2009 20:51:29 GMT

This is a multi-part message in MIME format.


DoLayoutAdaptation() is a good feature for wxDialog.
I note it removes focus from any control in the dialog, which is probably unavoidable given the reparenting of controls, but then focus defaults to the default button.
When using ShowModal() there is no way to set focus back to where you want focus when the dialog is shown unless I am missing something.
Cheers, John
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<META content="MSHTML 6.00.6001.18183" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT face=Arial size=2>DoLayoutAdaptation() is a good feature for 
wxDialog.</FONT></DIV>
<DIV><FONT face=Arial size=2>I note it removes focus from any control in the 
dialog, which is probably unavoidable given the reparenting of 
controls, but then focus defaults to the default button.</FONT></DIV>
<DIV><FONT face=Arial size=2>When using ShowModal() there is no way to set focus 
back to where you want focus when the dialog is shown unless I am missing 
something.</FONT></DIV>
<DIV><FONT face=Arial size=2>Cheers, John</FONT></DIV></BODY></HTML>

by **Julian Smart** » Wed, 21 Jan 2009 21:08:29 GMT

Hi John,



Good point - maybe we need to change wxDialogBase::DoLayoutAdaptation() 
in src/common/dlgcmn.cpp to something like this:

/// Do the adaptation
bool wxDialogBase::DoLayoutAdaptation()
{
    if (GetLayoutAdapter())
    {
        wxWindow* focusWindow = wxFindFocusDescendant(this); // from event.h
        if (GetLayoutAdapter()->DoLayoutAdaptation((wxDialog*) this))
        {
            if (focusWindow)
                focusWindow->SetFocus();
            return true;
        }
        else
            return false;
    else
        return false;
}

Perhaps you could try this and if it helps, I can add it to SVN?

Thanks,

Julian

-- 
Julian Smart, Anthemion Software Ltd.
28/5 Gillespie Crescent, Edinburgh, Midlothian, EH10 4HU
www.anthemion.co.uk | +44 (0)131 229 5306
Tools for writers: www.writerscafe.co.uk
wxWidgets RAD:     www.dialogblocks.com
Blog:              www.juliansmart.com

by **John Roberts** » Thu, 22 Jan 2009 20:44:09 GMT

----- Original Message ----- 
From: "Julian Smart" < XXXX@XXXXX.COM >
To: < XXXX@XXXXX.COM >
Sent: Tuesday, January 20, 2009 9:08 PM
Subject: Re: DoLayoutAdaptation()

Tested and works a treat.
wxFindFocusDescendant(this); // from event.h I will have to have a look at 
this when I get time ( not in my doxygen gen .chm help)
Before you commit, add the closing brace between the first "return false" 
and the last "else".
Cheers, John

DoLayoutAdaptation()

DoLayoutAdaptation()

Jump to:

Next

DoLayoutAdaptation()

Re: DoLayoutAdaptation()

Re: DoLayoutAdaptation()

Who is online